This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [testsuite, build] Convert boehm-gc testsuite to DejaGnu (PR boehm-gc/11412)
- From: Rainer Orth <ro at CeBiTec dot Uni-Bielefeld dot DE>
- To: Mike Stump <mikestump at comcast dot net>
- Cc: IainS <developer at sandoe-acoustics dot co dot uk>, Ralf Wildenhues <Ralf dot Wildenhues at gmx dot de>, GCC Patches <gcc-patches at gcc dot gnu dot org>, Hans Boehm <hans_boehm at hp dot com>, Paolo Bonzini <bonzini at gnu dot org>, Ben Elliston <bje at gnu dot org>
- Date: Tue, 22 Feb 2011 18:14:45 +0100
- Subject: Re: [testsuite, build] Convert boehm-gc testsuite to DejaGnu (PR boehm-gc/11412)
- References: <ydd62u3p6m7.fsf@manam.CeBiTec.Uni-Bielefeld.DE> <20110106211734.GG17791@gmx.de> <yddvd1nybjy.fsf@manam.CeBiTec.Uni-Bielefeld.DE> <CEFCDD75-F193-4D33-8B56-FA1A817FBE15@sandoe-acoustics.co.uk> <yddfwsiwgcn.fsf@manam.CeBiTec.Uni-Bielefeld.DE> <E8CE6E4B-D599-45DE-BA43-7BB76BB051D2@comcast.net>
Mike Stump <mikestump@comcast.net> writes:
> On Jan 24, 2011, at 6:01 AM, Rainer Orth wrote:
>> + # FIXME: Explain options.
>> + set shopt "-version-info 1:2:0 -no-undefined -rpath /nowhere"
>> + # Prefix -shared-libgcc with -Wc, to get it through libtool.
>> + lappend shopt -Wc,-shared-libgcc
>
> Seems not very portable... though, maybe it really is.
I has to be used for a couple of target libraries already, so using it
in the testsuite doesn't make things worse (provided we're allowed to
assume that the testsuite are only run with gcc, not vendor compilers).
>> + catch { exec $libtool --mode=clean rm -f $basename.lo }
>
> If libtool runs on the host, this doesn't do that, try:
>
> [remote_exec host ... ]
>
> see gcc.exp for examples.
>
>> + catch { exec $libtool --mode=clean rm -f [file rootname [file tail $testcase]] $shlib }
>
> Likewise.
Ok, will do.
> Other than that, looks reasonable. Though, I'd probably say, stage1, as I said earlier. If you want it for the current release, we can also ask a RM to weigh in... I'd be fine with them preferring it sooner, if they want.
I don't think the benefit outweighs the risk: we've lived with a non-dg
testsuite for years (even the PR is 7.5 years old), so I see no need to
hurry.
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University