This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch, IRA] Fix PR46002
- From: Jeff Law <law at redhat dot com>
- To: Chung-Lin Tang <cltang at codesourcery dot com>
- Cc: gcc-patches <gcc-patches at gcc dot gnu dot org>, "Vladimir N. Makarov" <vmakarov at redhat dot com>
- Date: Mon, 21 Feb 2011 10:24:30 -0700
- Subject: Re: [patch, IRA] Fix PR46002
- References: <4D5FC048.4050504@codesourcery.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 02/19/11 06:06, Chung-Lin Tang wrote:
> Hi Vladimir,
> Thanks for reviewing my other patch for PR46178. Although you mentioned
> the priority algorithm is bound for removal, I still have another
> related patch.
>
> This fix is for PR46002: during update_copy_costs(), when we obtain the
> cover class for a copy-related allocno, it is not sufficient to test if
> the two reg-classes intersect; the assigned register in the current
> allocno must be *in* in the intersection. Otherwise the classes may
> intersect, but the currently assigned register is not valid for
> assigning to the other allocno (then ICE in the index >= 0 assertion).
>
> This patch changes the copy skipping test, from testing cover class
> intersection, into a test of if 'hard_regno' is within the cover class
> of 'another_allocno'.
>
> Bootstrapped and tested on x86_64 with no regressions. Comparing test
> results under -fira-algorithm=priority also shows many fewer FAILs. Okay
> for trunk?
>
>
> Thanks,
> Chung-Lin
>
> 2011-02-19 Chung-Lin Tang <cltang@codesourcery.com>
>
> PR rtl-optimization/46002
> * ira-color.c (update_copy_costs): Change class intersection
> test to reg_class_contents[] test of 'hard_regno'.
FYI: In the interest of getting these two PRs wrapped up, I've twiddled
the testcases from the PRs into suitable tests for the testsuite and
will be checking them in shortly.
jeff
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
iQEcBAEBAgAGBQJNYp/OAAoJEBRtltQi2kC7IYgH+wZyCMSk0dW5FqaXGgnUnvxZ
1141vzN2dLptAculbeM/p5shW9Tm1SL/P3vyO2YrsXs3F25mzqsb7V0Uz947eTfm
JIspqA0h754YhieDzKVh5/9edNRyyrbzGCvCYLMXiN7TLHOs+CJm+DkjWMQbbLWh
NfhAR/ZMDl+MilmVnmkQrKKBgXVKttmLquNlVEgZJ5N3E+YuSUPoihQ+6/PueL3H
BypHxXHBTxWD7heynJJ8RFDJ6n4NJB8/qr4OMDp2GNYfLdIerHzMhP69jwwO3M9m
uZW6JhqXkE5UPzhjvqXaYFRYpzn/5L0JGYlOqv0R8rsUfZtOZ3DGhRJQxuojOXA=
=jEMH
-----END PGP SIGNATURE-----