This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch ObjC/Darwin 1/3] Fix wrong code gen for m64 Objective-C


Hi Nicola,

On 16 Feb 2011, at 21:55, Nicola Pero wrote:

Hmmm. Ok, I had not read objc_eh_runtime_type() yet. I see you
changed
things there. It used to just emit the class name, it now tries to
look
it up in the class names that have already been emitted, presumably to
unique class names emitted in the object file.


I hope that doesn't break anything.

ummm... exceptions don't work for GNU Objective-C++

Sure - I was thinking of GNU Objective-C here. Isn't objc_eh_runtime_type()
used for exceptions with GNU Objective-C ?

It is,


... and I would be amongst the first to admit that our test-suite is imperfect.

However, that is primarily lack of cover...
... in the case of exceptions we have a fairly reasonable number of tests (including execute and torture ones).


If we have so little confidence in that ..
.. then I feel we need to put any development to one side until we can convince ourselves that we have the ability to test whether we made working code.


----

out of time for today -- I will address the next set of observations as time permits.

cheers
Iain



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]