This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch ObjC/Darwin 1/3] Fix wrong code gen for m64 Objective-C
- From: Richard Guenther <rguenther at suse dot de>
- To: Mike Stump <mikestump at comcast dot net>
- Cc: IainS <developer at sandoe-acoustics dot co dot uk>, GCC Patches <gcc-patches at gcc dot gnu dot org>, Nicola Pero <nicola dot pero at meta-innovation dot com>, "Joseph S. Myers" <joseph at codesourcery dot com>
- Date: Tue, 15 Feb 2011 11:10:01 +0100 (CET)
- Subject: Re: [Patch ObjC/Darwin 1/3] Fix wrong code gen for m64 Objective-C
- References: <693A7472-3577-43AA-97B1-D5C2899651FC@sandoe-acoustics.co.uk> <1604841D-47C5-4852-9730-FAF7A92DAC06@comcast.net>
On Mon, 14 Feb 2011, Mike Stump wrote:
> On Feb 14, 2011, at 5:16 AM, IainS wrote:
> > Whilst we are in stage-4, I believe that Richard (G) indicated that wrong-code bugs were eligible for inclusion, even at this stage.
>
> This work is Ok for the parts that I can approve. The open question is check it in now, or later during stage1? Since we're in a regression and doc phase, I think we need a RM to approve this for inclusion. RMs?
Generally wrong-code fixes are ok. Note that Objective-C is not release
critical, so we will not wait with a release in case you broke ObjC with
this patch and the release critical parts of the compiler are ready.
Thus, for non-release critical patches that fall in the regression /
wrong-code area the respective maintainers should decide whether the
advantage of including the patch outweights the risks.
Richard.