This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch, fortran] Document libgfortran thread-safety
On Mon, Feb 7, 2011 at 21:32, Tobias Burnus <burnus@net-b.de> wrote:
> On 02/07/2011 08:21 PM, Janne Blomqvist wrote:
>>
>> Ok, fixed. I also took the liberty of fixing a few other spurious
>> ()'s, and one bug (errno is a variable, not a function).
>
> Thanks for cleaning up the documentation.
>
> Nitpick 1: errno can also be a macro. (Cf. POSIX or the comment in
> gfortran.texi.) [No action required.]
Well yes, but certainly it's not a function which the documentation
previously stated! But, point taken. Any ideas for a proper, short,
and easy to understand wording? As Steve mentions, properly it's a
"modifiable lvalue of type int", but that might be somewhat of a
mouthful for a Fortran programmer not well versed in C.
>> Committed revision 169893.
>
> Nitpick 2: I would prefer if you could also include the patch in the commit
> message. I think there is an increasing tendency to avoid
> attaching/including patches for obvious commits. For me it is much faster to
> browse through a commit diff in an email than to access the patch via "svn
> diff".
Ok, I'll try to remember that.
FWIW, I'm using git for my gcc development, where diff's between
arbitrary revisions is blazing fast (compared to svn, at least) and
usually quite simple, so I personally don't see it as a big issue to
have to check my own tree. But, not everybody is on the git bandwagon
(yet?)..
--
Janne Blomqvist