This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [trans-mem] handle invisible references for decls (PR/47554)

From: Aldy Hernandez <aldyh at redhat dot com>
To: Richard Guenther <richard dot guenther at gmail dot com>
Cc: Richard Henderson <rth at redhat dot com>, gcc-patches <gcc-patches at gcc dot gnu dot org>
Date: Mon, 07 Feb 2011 13:13:09 -0600
Subject: Re: [trans-mem] handle invisible references for decls (PR/47554)
References: <4D4C5CC2.2060205@redhat.com> <4D4C61BE.9010805@redhat.com> <AANLkTinRYeoyMrLi-10dcKWgbQvuwNbJc1qj8w_Xcp18@mail.gmail.com>

I sincerely believe that the test in aggregate_value_p is a mistake.
We should not be lying about the fact that this value is a pointer.
But looking at how DECL_BY_REFERENCE is used elsewhere, it'll be a
hard one to unravel.  And that certainly should not be done on this
branch.


Hm, I think we fixed this on trunk and DECL_BY_REFERENCE result-decls
are now even in SSA form.

Thanks Richi. I have put a note on the source to double check the existence of this failure after the next (long over due) merge.

Committed as obvious.

Aldy

Attachment: curr
Description: Text document

References:
- [trans-mem] handle invisible references for decls (PR/47554)
  - From: Aldy Hernandez
- Re: [trans-mem] handle invisible references for decls (PR/47554)
  - From: Richard Henderson
- Re: [trans-mem] handle invisible references for decls (PR/47554)
  - From: Richard Guenther

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]