Re: Another Python namespace pollution (was: r147958 - in /trunk/libstdc++-v3: ChangeLog Mak...)

[Gary Benson <gbenson at redhat dot com>]

Gary Benson wrote:
> Richard Guenther wrote:
> > On Thu, Jan 27, 2011 at 11:38 AM, Gary Benson <gbenson@redhat.com> wrote:
> > > Gerald Pfeifer wrote:
> > > > I noticed that coming from the Java side of things we also
> > > > have two files that are installed in common namespace:
> > > >
> > > >   share/python/aotcompile.py
> > > >   share/python/classfile.py
> > >
> > > I'm on the hook to fix this, but it's been a while since I
> > > worked on this stuff so I'm a little out of touch with GCC.
> > > Can you tell me what you mean by "common namespace", and
> > > what the alternative should be?
> > 
> > The files should reside in a directory that is private to gcc or
> > at least mangled with the gcc version it comes from.  Otherwise
> > multiple parallel gcc installations conflict.
> 
> Ah, ok, that shouldn't be too hard.  I'll get working on a patch.

Ha ha, famous last words, I've been fighting this for days.

Ok, attached is a patch that causes the two Python modules to be
installed in a versioned directory.  Also attached is a separate
patch, orthogonal to the first, which changes how the modules are
made available to the aot-compile scripts.  What is currently in
svn adds the directory to the _end_ of the path, so if the modules
exist elsewhere then the other versions will take priority.  The
attached patch changes it to add the directory to the start of the
path.

If the patches are ok then could someone please commit them for me?
I thought I had commit access, but I couldn't seem to check out a
tree using ssh, so maybe it was revoked for inactivity :)

Cheers,
Gary

-- 
http://gbenson.net/

Attachment: aot-compile-fix-take-1.patch
Description: Text document

Attachment: aot-compile-improvement.patch
Description: Text document