This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch, arm] Backport PR45094 fix to 4.5
- From: Richard Earnshaw <rearnsha at arm dot com>
- To: Ramana Radhakrishnan <ramana dot gcc at googlemail dot com>
- Cc: Yao Qi <yao at codesourcery dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Fri, 28 Jan 2011 14:29:58 +0000
- Subject: Re: [patch, arm] Backport PR45094 fix to 4.5
- References: <4D184B17.1030106@codesourcery.com> <AANLkTinrCwORdwszLSEfpDRBbrqhcdpucFy22q4hJDU-@mail.gmail.com>
On Wed, 2011-01-26 at 12:16 +0000, Ramana Radhakrishnan wrote:
> On Mon, Dec 27, 2010 at 8:15 AM, Yao Qi <yao@codesourcery.com> wrote:
> > PR 45094 was fixed by this patch on mainline
> > http://gcc.gnu.org/ml/gcc-patches/2010-08/msg00249.html. This patch is
> > to backport this fix to 4.5 branch.
> > Note that since 'dg-add-options arm_neon' doesn't work on 4.5 branch, it
> > is replaced by '-mfpu=neon -mfloat-abi=softfp' in dg-options.
>
> I can't approve or reject your patch but is there any reason why that
> bit of testsuite infrastructure can't be backported to 4.5 ? Otherwise
> this test will fail regularly on hardware where you have no neon.
>
> cheers
> Ramana
> >
> > OK for 4.5?
> >
> > --
> > Yao (éå)
> >
>
The patch to the compiler is a good thing. In the interests of
stability I just suggest that we don't bother back-porting the test if
it will cause problems. It's a useful test for long-term validation of
trunk, but not of great value on the branch.
R.