This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fail when PPL 0.11 is not present and CLooG has been requested.
Jakub Jelinek <jakub@redhat.com> writes:
> On Tue, Jan 25, 2011 at 07:50:16AM -0800, Ian Lance Taylor wrote:
>> On Tue, Jan 25, 2011 at 5:14 AM, Jakub Jelinek <jakub@redhat.com> wrote:
>
>> > Â CLOOG_REQUESTED([graphite_requested=yes], [graphite_requested=no])
>> > - Âif test "${graphite_requested}" = yes; then
>> > + Âif test "${graphite_requested}" = yes -a "x${with_cloog}" != xno; then
>> > Â Â AC_MSG_ERROR([Unable to find a usable PPL. ÂSee config.log for
>> > details.])]
>> > Â fi
>> > + Âwith_cloog=no
>> > Âfi
>> > Âif test "x${with_cloog}" = x && test "x${with_cloog_include}" = x \
>> > Â && test "x${with_cloog_lib}" = x && test -d ${srcdir}/cloog; then
>>
>> It seems to me that CLOOG_REQUESTED in config/cloog.m4 should test for
>> with_cloog=no.
>
> I agree about that.
>
>> That seems like the right thing to do in any case, and it seems that
>> it would fix this problem.
>
> But the with_cloog=no move is needed anyway, otherwise it would on the
> other side never error out.
Good point.
I'll preapprove a patch which moves with_cloog=no and fixes
CLOOG_REQUESTED, assuming it bootstraps.
Ian