Re: [PATCH] Fail when PPL 0.11 is not present and CLooG has been requested.

["H.J. Lu" <hjl dot tools at gmail dot com>]

On Tue, Jan 25, 2011 at 6:42 AM, Sebastian Pop <sebpop@gmail.com> wrote:
> On Tue, Jan 25, 2011 at 07:45, Richard Guenther
> <richard.guenther@gmail.com> wrote:
>> On Tue, Jan 25, 2011 at 2:41 PM, Richard Guenther
>> <richard.guenther@gmail.com> wrote:
>>> On Tue, Jan 25, 2011 at 2:14 PM, Jakub Jelinek <jakub@redhat.com> wrote:
>>>> On Tue, Jan 25, 2011 at 05:04:37AM -0800, H.J. Lu wrote:
>>>>> On Tue, Jan 25, 2011 at 5:02 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
>>>>> > On Mon, Jan 24, 2011 at 11:58 PM, Eric Botcazou <ebotcazou@adacore.com> wrote:
>>>>> >>> 2011-01-18 ?Sebastian Pop ?<sebastian.pop@amd.com>
>>>>> >>>
>>>>> >>> ? ? ? * configure.ac: Call AC_MSG_ERROR when PPL 0.11 is not present and
>>>>> >>> ? ? ? CLooG has been requested.
>>>>> >>> ? ? ? * configure: Regenerated.
>>>>> >>
>>>>> >> configure fails unconditionally on the mainline:
>>>>> >>
>>>>> >> checking for version 0.11 (or later revision) of PPL... no
>>>>> >> configure: error: Unable to find a usable PPL. ?See config.log for details.
>>>>> >>
>>>>> >
>>>>> > http://gcc.gnu.org/install/prerequisites.html
>>>>> >
>>>>> > still says "CLooG-PPL version 0.15".
>>>>>
>>>>> I meant "Parma Polyhedra Library (PPL) version 0.10".
>
> I will fix http://gcc.gnu.org/install/prerequisites.html
>
>>>>
>>>> I think something like:
>>>>
>>>> --- configure.ac ? ? ? ?2011-01-25 12:58:42.145421312 +0100
>>>> +++ configure.ac ? 2011-01-25 14:10:47.473670333 +0100
>>>> @@ -1688,13 +1688,12 @@ dnl Provide configure switches and initi
>>>> ?dnl with user input.
>>>> ?CLOOG_INIT_FLAGS
>>>> ?if test "x$with_ppl" = "xno"; then
>>>> - ?with_cloog=no
>>>> -
>>>> ? dnl Only execute fail-action, if CLooG has been requested.
>>>> ? CLOOG_REQUESTED([graphite_requested=yes], [graphite_requested=no])
>>>> - ?if test "${graphite_requested}" = yes; then
>>>> + ?if test "${graphite_requested}" = yes -a "x${with_cloog}" != xno; then
>>>> ? ? AC_MSG_ERROR([Unable to find a usable PPL. ?See config.log for
>>>> details.])]
>>>> ? fi
>>>> + ?with_cloog=no
>>>> ?fi
>>>> ?if test "x${with_cloog}" = x && test "x${with_cloog_include}" = x \
>>>> ? && test "x${with_cloog_lib}" = x && test -d ${srcdir}/cloog; then
>>>>
>>>> could fix this (CLOOG_REQUESTED checks if with_cloog* is empty, but
>>>> --without-cloog shouldn't certainly be considered to be requesting graphite
>>>> and the unconditional setting of with_cloog=no before the check makes it
>>>> unconditional.
>
> Looks good. ?Thanks for the fix.
>
>>>>
>>>> That said, I'm quite unhappy about the new PPL version requirement, was it
>>>> really necessary at this point in 4.6 development (also the cloog-ppl
>>>> requirement)? ?It will cause quite a lot of hassles to many of the
>>>> distributions.
>
> With PPL 0.10 most of the interchange testcases will fail to be interchanged.
>
>>> Indeed :/ ?While the next openSUSE will have PPL 0.11 it will not yet
>>> have cloog 0.16.1 (I didn't even realize that was available already).
>>
>> Btw, in the infrastructure directory I see cloog-0.16.1 and cloog-parma-0.16.1.
>> What is the difference between both and which one should be used?
>
> Please use cloog-0.16.1 that is CLooG.org based on the ISL back-end.
>
> cloog-parma-0.16.1 is CLooG.org based on the PPL back-end. ?It is also
> usable but has some extra problems I have not yet addressed:
> ?- 47127 P3 gcc.dg/graphite/id-14.c ICEs with cloog-parma
> ?- 47128 P3 gcc.dg/graphite/pr43012.c ICEs with cloog-parma
>

It requires cloog-0.16.1 and cloog-parma-0.16.1 doesn't work. Why isn't
--enable-cloog-backend=isl the default?

-- 
H.J.