This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PATCH: PR target/47318: _mm256_maskstore_pd has wrong prototype
- From: Uros Bizjak <ubizjak at gmail dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Mon, 17 Jan 2011 08:51:47 +0100
- Subject: Re: PATCH: PR target/47318: _mm256_maskstore_pd has wrong prototype
- References: <20110116210438.GA4527@intel.com>
On Sun, Jan 16, 2011 at 10:04 PM, H.J. Lu <hongjiu.lu@intel.com> wrote:
> Mask operand of AVX mask load/store insns have the wrong type. ?This
> patch fixes it. ?OK for trunk/4.5/4.4?
> 2011-01-16 ?H.J. Lu ?<hongjiu.lu@intel.com>
>
> ? ? ? ?PR target/47318
> ? ? ? ?* config/i386/avxintrin.h (_mm_maskload_pd): Change mask to
> ? ? ? ?__m128i.
> ? ? ? ?(_mm_maskstore_pd): Likewise.
> ? ? ? ?(_mm_maskload_ps): Likewise.
> ? ? ? ?(_mm_maskstore_ps): Likewise.
> ? ? ? ?(_mm256_maskload_pd): Change mask to __m256i.
> ? ? ? ?(_mm256_maskstore_pd): Likewise.
> ? ? ? ?(_mm256_maskload_ps): Likewise.
> ? ? ? ?(_mm256_maskstore_ps): Likewise.
>
> ? ? ? ?* config/i386/i386-builtin-types.def: Updated.
> ? ? ? ?(ix86_expand_special_args_builtin): Likewise.
>
> ? ? ? ?* config/i386/i386.c (bdesc_special_args): Update
> ? ? ? ?__builtin_ia32_maskloadpd, __builtin_ia32_maskloadps,
> ? ? ? ?__builtin_ia32_maskloadpd256, __builtin_ia32_maskloadps256,
> ? ? ? ?__builtin_ia32_maskstorepd, __builtin_ia32_maskstoreps,
> ? ? ? ?__builtin_ia32_maskstorepd256 and __builtin_ia32_maskstoreps256.
>
> ? ? ? ?* config/i386/sse.md (avx_maskload<ssemodesuffix><avxmodesuffix>):
> ? ? ? ?Use <avxpermvecmode> on mask register.
> ? ? ? ?(avx_maskstore<ssemodesuffix><avxmodesuffix>): Likewise.
>
> gcc/testsuite/
>
> 2011-01-16 ?H.J. Lu ?<hongjiu.lu@intel.com>
>
> ? ? ? ?PR target/47318
> ? ? ? ?* gcc.target/i386/avx-vmaskmovpd-1.c: New.
> ? ? ? ?* gcc.target/i386/avx-vmaskmovpd-2.c: Likewise.
> ? ? ? ?* gcc.target/i386/avx-vmaskmovps-1.c: Likewise.
> ? ? ? ?* gcc.target/i386/avx-vmaskmovps-1.c: Likewise.
>
> ? ? ? ?* gcc.target/i386/avx-vmaskmovpd-256-1.c (avx_test): Load mask
> ? ? ? ?as __m256i.
> ? ? ? ?* gcc.target/i386/avx-vmaskmovpd-256-2.c (avx_test): Likewise.
> ? ? ? ?* gcc.target/i386/avx-vmaskmovps-256-1.c (avx_test): Likewise.
> ? ? ? ?* gcc.target/i386/avx-vmaskmovps-256-2.c (avx_test): Likewise.
OK.
Thanks,
Uros.