Re: [patch java]: Intialize va_list_type_node to avoid segfault for x86_64 targets in respect for alignment

["H.J. Lu" <hjl dot tools at gmail dot com>]

On Fri, Jan 7, 2011 at 11:20 AM, Kai Tietz <ktietz70@googlemail.com> wrote:
> 2011/1/7 H.J. Lu <hjl.tools@gmail.com>:
>> On Fri, Jan 7, 2011 at 5:51 AM, Kai Tietz <ktietz70@googlemail.com> wrote:
>>> 2011/1/7 Andrew Haley <aph@redhat.com>:
>>>> On 01/07/2011 11:42 AM, Kai Tietz wrote:
>>>>>
>>>>> Hello,
>>>>>
>>>>> we noticed that java doesn't initialize in decl.c
>>>>> (java_init_decl_processing) the va_list_type_node. This leads to
>>>>> issues in some architectures for wrong checks and/or ICE (as for
>>>>> x86_64 one in i386.c (ix86_local_alignment)).
>>>>>
>>>>> ChangeLog
>>>>>
>>>>> 2011-01-07 ?Kai Tietz
>>>>>
>>>>> ? ? ? ? * decl.c (java_init_decl_processing): Setup va_list_type_node.
>>>>>
>>>>> Tested for i686-pc-cygwin and x86_64-w64-mingw32. Ok for apply?
>>>>
>>>> Sure.
>>>>
>>>> Andrew.
>>>>
>>>
>>> Ok, applied to trunk at revision 168569. Is this patch ok for 4.5 branch, too?
>>>
>>>
>>
>> This caused:
>>
>> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47215
>>
>>
>>
>> --
>> H.J.
>>
>
> Hmm, I see that java doesn't initialize unsigned_type_node. HJ does it
> solve the issue if you add 'unsigned_type_node = make_unsigned_type
> (INT_TYPE_SIZE);' before the target hook in java/decl.c 't =
> targetm.build_builtin_va_list ();' is called?
>

Please send me a proper patch.

Thanks.

-- 
H.J.