This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: forward_list debug swap

From: François Dumont <francois dot cppdevs at free dot fr>
To: Paolo Carlini <paolo dot carlini at oracle dot com>
Cc: libstdc++ at gcc dot gnu dot org, gcc-patches at gcc dot gnu dot org
Date: Wed, 05 Jan 2011 21:58:27 +0100
Subject: Re: forward_list debug swap
References: <4D223092.8050502@free.fr> <4D223A8F.3030104@oracle.com>

This is the patch finally applied.

2011-01-05 François Dumont <francois.cppdevs@free.fr>

        * include/debug/safe_base.h (_Safe_iterator_base::_M_unlink): New.
        * include/src/debug.cc: Use latter
        * include/debug/forward_list (forward_list<>::_M_swap):  Fix to
        correctly handle before_begin iterators.
        * testsuite/23_containers/forward_list/debug/swap.cc: Remove now
        useless _GLIBCXX_DEBUG checks.

I realized that _M_version fields in _Safe_iterator_base and _Safe_sequence_base are useless for a sequence like the forward_list. I will consider this optimization for a future (binary incompatible) evolution of the debug mode.

Regards

On 01/03/2011 10:07 PM, Paolo Carlini wrote:

Ok, but please properly format the code: no overlong lines, newline
after the return type of the function and after the double colon for
member functions.

Paolo.

Attachment: forward_list_debug_swap.patch
Description: Text document

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]