This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 3/4] Code generation for OpenCL.
On Sat, 25 Dec 2010, Sebastian Pop wrote:
> +#include "tm.h"
Why does this file need tm.h?
> +#include "rtl.h"
Or, why does it need rtl.h, since rtl.h needs tm.h? I'd have thought
graphite-* files should be higher level than that.
> +#include <sys/time.h>
Please don't include random system headers in individual source files
unless there is a good reason. system.h already includes sys/time.h under
appropriate conditions based on configure tests.
> +#include "tree.h"
This is the second include of tree.h in this new file. I think you need
to review all the includes carefully and work out which are actually
needed - and of course update makefile dependencies after fixing
unnecessary includes.
The same comments apply to at least two files added by this patch.
--
Joseph S. Myers
joseph@codesourcery.com