This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch, Darwin] Fix PR46904/PR46916
On Dec 20, 2010, at 2:19 AM, IainS <developer@sandoe-acoustics.co.uk> wrote:
> On 18 Dec 2010, at 18:58, Mike Stump wrote:
>
>> On Dec 17, 2010, at 1:37 AM, IainS wrote:
>>> This has now been regstrapped on *-darwin9 and x86_64-darwin10.
>>>
>>> There are outstanding issues with -freorder-blocks-and-partition (on Darwin, at least) which results in the fail of partition2.C on Darwin10.
>>
>> :-( I kinda hate regressions.... and the opt.c change I kinda wish were broken out, either, it goes in first, or it goes in second.
>
> makes sense... see below.
>
>> Normally, I'd say since I think the changes for the two remaining problems are well underway, I'd propose to stage in the fixes for those first, before the below goes in, so that when it does go in, there are no regressions, but, the problem with that is this patch is to `fix' regressions, and as I said, I hate regressions....
>>
>> so...
>>
>>> OK for trunk?
>>
>> Ok.
>
> So, to address your concerns...
>
> I applied two patches - the first to fix the regressions
Ok, thanks.
>