This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] PR44482; Add missing prototypes in soft-fp
On Tue, Dec 21, 2010 at 09:45:25AM +0100, Jakub Jelinek wrote:
> On Mon, Dec 20, 2010 at 09:41:43PM -0500, Jack Howarth wrote:
> > The attached patch adds the missing prototypes to the source files in
> > config/soft-fp so that the numerous "no previous prototype" warnings are
> > eliminated when -Wmissing-prototypes is used. Bootstrap and regression tested
> > on x86_64-apple-darwin10 (-m32/-m64). Okay for gcc trunk?
>
> No. soft-fp is imported from glibc, so changes need to go there first.
> And such changes are very unlikely to be accepted there, prototypes right
> before function definition are really useless but to silence a warning that
> can be easily turned off when compiling soft-fp files.
> If anything, the prototypes could be provided by a common header, if you
> pick one of the GCC owned instead of soft-fp owned, you wouldn't even have
> to change glibc for that.
Jakub,
Looking at the preprocessed source for fixtfsi.i, it is difficult to see
where one could jam a gcc specific header into the build without either
adding a new include into the soft-fp source files or hard coding the
explicit include into the Makefile.in file itself. So it looks like disabling
-Wmissing-prototypes for soft-fp is the path of least resistance.
> Jakub