This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Ping**2][PATCH] fix PR pch/45979 regression on recent ARM/Linux kernels
- From: Mikael Pettersson <mikpe at it dot uu dot se>
- To: Steven Bosscher <stevenb dot gcc at gmail dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, Richard Earnshaw <rearnsha at arm dot com>, Paul Brook <paul at codesourcery dot com>, mikpe at it dot uu dot se
- Date: Mon, 6 Dec 2010 02:46:47 +0100
- Subject: Re: [Ping**2][PATCH] fix PR pch/45979 regression on recent ARM/Linux kernels
- References: <AANLkTi=fRdL8q6YP0UjspgAd4GGvFNF2U5fdZUeM4Znv@mail.gmail.com>
Steven Bosscher writes:
> Hello,
>
> There is a pending patch for bugzilla PR pch/45979, that was submitted
> more than a month ago, and pinged:
>
> http://gcc.gnu.org/ml/gcc-patches/2010-10/msg02252.html
> http://gcc.gnu.org/ml/gcc-patches/2010-11/msg02003.html
>
> The bug concerns a PCH failure related to heap randomization, and the
> proposed patch for it is really small and seemingly obvious. Of
> course, in typical GCC style, the patch has received absolutely no
> feedback at all from anyone, including ARM maintainers.
>
> It continues to amaze me how there can be discussions in the gcc
> community about being more open to new contributors, or improving the
> patch commit/review process, when at the same time even this kind of
> small patches just is ignored. But oh well, SEP...
>
> Could someone be so kind to have a look at the patch and ack or nack it?
It may be that this patch was overlooked, but there is also an
issue of an absent copyright assignment that the GCC folks now
have decided is needed but I'm not yet able to supply (due to my
new employer's tardiness in issuing a disclaimer). Until that's
sorted, I'm not posting any more patches (so as to not prevent
anyone else from implementing the same fixes for future bugs).
>
> Ciao!
> Steven
>
>
> 2010-xx-xx Mikael Pettersson <mikpe at it dot uu dot se>
>
> PR pch/45979
> * config/host-linux.c (TRY_EMPTY_VM_SPACE): Define for __ARM_EABI__.
>
> --- gcc-4.6-20101009/gcc/config/host-linux.c.~1~ 2009-02-20
> 16:20:38.000000000 +0100
> +++ gcc-4.6-20101009/gcc/config/host-linux.c 2010-10-13 15:24:28.000000000 +0200
> @@ -86,6 +86,8 @@
> # define TRY_EMPTY_VM_SPACE 0x60000000
> #elif defined(__mc68000__)
> # define TRY_EMPTY_VM_SPACE 0x40000000
> +#elif defined(__ARM_EABI__)
> +# define TRY_EMPTY_VM_SPACE 0xa0000000
> #else
> # define TRY_EMPTY_VM_SPACE 0
> #endif
>