This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: RFA: partially hookize *_TYPE_SIZE
On Tue, Nov 30, 2010 at 12:33 PM, Joseph S. Myers
<joseph@codesourcery.com> wrote:
> On Mon, 29 Nov 2010, Joern Rennecke wrote:
>
>> This hookizes *_TYPE_SIZE for frontends and tree optimizers, as discussed
>> in PR46677.
>
> This is partial in the sense that not all uses are converted (note that
> I'm counting uses in headers such as config/glibc-stdint.h as well, and
> uses in target code including libgcc/config/libbid/bid_gcc_intrinsics.h)
> and so it is not possible to start converting targets to define the hooks
> instead of the macros. ?(A comment to make things clear for anyone who
> might want to start the actual conversions of targets, not an objection.)
>
> (Also partial in that it doesn't have hooks for decimal floating-point
> types or fixed-point types, but that's certainly not a problem. ?For
> decimal floating-point types there are no non-default definitions of the
> macros and they are used only in one place so that conversion will be
> pretty trivial.)
>
> I'm not convinced it makes sense to be partial in this way for
> BOOL_TYPE_SIZE (a single non-default definition) and ADA_LONG_TYPE_SIZE
> (two non-default definitions) rather than just doing the complete
> conversions for those macros and poisoning them.
Btw, I think these partial conversions are not appropriate for stage3
and if accepted for stage1 you should commit yourself to do a
transition that at least allows converting targets (thus, I don't like
your incremental patches at all).
Richard.