This is the mail archive of the mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH, PR46650][Revisedx2] Fix --enable-build-with-cxx bootstrap failure

* Jack Howarth wrote on Sun, Nov 28, 2010 at 06:12:41PM CET:
>   Currently the --enable-build-with-cxx bootstrap is broken due to r167010
> which poisoned the strerror macro. The attached patch includes the cstring c++
> header when __cplusplus is defined. The previous includes for string.h and
> strings.h are left in place for symbols like strcasecmp. Bootstrap and
> regression tested on x86_64-apple-darwin10. Corrected path in ChangeLog
> entry.
> Okay for gcc trunk?

FWIW, I cannot approve this.  I also don't know if there is a chance
that cstring and string.h may conflict anywhere; barring more experience
it seems worth a try though.


> 2010-11-27  Jack Howarth <>
>             Joseph Myers <>
>         PR bootstrap/46650
>         * system.h: Include cstring for cxx bootstrap.

> --- gcc/system.h	(revision 167217)
> +++ gcc/system.h	(working copy)
> @@ -194,6 +194,10 @@
>     rely on (and therefore test) GCC's string builtins.  */
>  #define __NO_STRING_INLINES
> +#ifdef __cplusplus
> +# include <cstring>
> +#endif
> +
>  # include <string.h>
>  # include <strings.h>

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]