This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] introduce __FLOAT_WORD_ORDER__ in lieu of LIBGCC2_FLOAT_WORDS_BIG_ENDIAN
On Sat, Nov 27, 2010 at 11:17:31PM +0000, Joseph S. Myers wrote:
> On Sat, 27 Nov 2010, Nathan Froyd wrote:
> > Sorry about the breakage. I should have double-checked this on ARM. I
> > don't know that there's any better way to fix this at the moment than
> > including tm_p.h in cppbuiltin.c.
>
> The better way of avoiding a tm_p.h include is usually a target hook
> conversion of the relevant target macro (FLOAT_WORDS_BIG_ENDIAN). In the
> present case, the hook already exists purely as a targhooks.c wrapper to
> the macro; all the remaining users of the macro need to be converted to
> the hook before any targets can define the hook in place of the macro (but
> cppbuiltin.c could be changed on its own to use the hook like
> java/jcf-parse.c, without any of the other changes).
That would be better. I suppose the concerns about performance impact
from TARGET_FLOAT_WORDS_BIG_ENDIAN would be somewhat less than
converting BITS_PER_UNIT or WORDS_BIG_ENDIAN.
-Nathan