This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: More cgraph_remove_unreachable_nodes fixes


On Fri, Nov 26, 2010 at 11:34 AM, Jie Zhang <jie@codesourcery.com> wrote:
> Hi Jan,
>
> On 10/27/2010 05:34 AM, Jan Hubicka wrote:
>>
>> Hi,
>> cgraph_remove_unreachable_nodes still remove masters of clones from othr
>> partitions that confuse sanity checking. ?Fixed by the following patch
>> that
>> also cleans up how things are queued. Everything that is referenced by
>> live
>> part of cgraph is enqueued, everything that is really reachable gets
>> reachable
>> flag.
>>
>> Bootstrapped/regtested x86_64-linux, also lto-bootstrapped and comitted.
>> ? ? ? ?* ipa.c (process_references): Enqueue all referenced nodes;
>> ? ? ? ?mark as reachable only non-external nodes.
>> ? ? ? ?(cgraph_remove_unreachable_nodes): All referenced nodes should
>> ? ? ? ?be enqueued; remove bogues node->needed check.
>
> This patch causes a failure when building glibc for arm-none-linux-gnueabi
> target. The reduced test case is attached.
>
> Without this patch, memchr is defined in the assembly:
>
> ? ? ? ?.size ? __memchr, .-__memchr
> ? ? ? ?.weak ? __GI_memchr
> ? ? ? ?.hidden __GI_memchr
> ? ? ? ?.set ? ?__GI_memchr,__memchr
> ? ? ? ?.global memchr
> ? ? ? ?.set ? ?memchr,__GI_memchr
> ? ? ? ?.ident ?"GCC: (GNU) 4.6.0 20101026 (experimental)"
>
> but with this patch, memchr is not defined:
>
> ? ? ? ?.size ? __memchr, .-__memchr
> ? ? ? ?.weak ? __GI_memchr
> ? ? ? ?.hidden __GI_memchr
> ? ? ? ?.set ? ?__GI_memchr,__memchr
> ? ? ? ?.ident ?"GCC: (GNU) 4.6.0 20101026 (experimental)"
>
> When compiling the test case, -O is used on the command line.

Please also open a bugreport.

Thanks,
Richard.

>
> Regards,
> Jie
>


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]