This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch libquadmath]: Fix build of gfortran using libquadmath for pe-coff targets



On 23 Nov 2010, at 18:52, Kai Tietz wrote:


2010/11/23 Dave Korn <dave.korn.cygwin@gmail.com>:
On 21/11/2010 19:12, Kai Tietz wrote:
Hello,

by recent libquadmath patch there was a bootstrap issue for
i686-pc-cygwin, i686-pc-mingw32, and x86_64-w64-mingw32. I was
reasoned by some minor nits in configure and makefile AFAICS.

(libquadmath_la_LDFLAGS): Add -no-undefined.

Argh. This can have undesired side-effects on Darwin. It may have to only
be added for Windows hosts. (I have to fix this same problem for lto-plugin.)

Well, this is the same pattern as used in libssp. So if darwin has an issue here, we have more then one place in gcc doing this.

Well, maybe unconditionally overriding flags for all targets is probably prone to gotchas anyway.
For Darwin, it will cause an issue in the case that the linked object needs to resolve symbols dynamically.
(that might not be relevant here or to libssp - but it probably ought to be fixed there too).


(libquadmath_la_LINK): Commented out.

Should just be deleted unless there's a very special reason to need to keep
it around. History lives in svn revisions, not comments...

Yes, I commented it. It looked simply wrong to me, but I wanted first to make sure.

(libquadmath_la_DEPENDENCIES): Add ibquadmath_la_LIBADD.

Missing an 'l' there!

Thanks.


   cheers,
     DaveK

there are still other wrinkles to iron out ---
... bootstrap is broken for i686-darwin8 on 32 bit hardware when fortran is enabled
(but I've not had a chance to analyze why, beyond that it's related to libquadmath).


Iain


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]