This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [gccgo] toplevel check-go target


Ralf Wildenhues <Ralf.Wildenhues@gmx.de> writes:

> This allows 'make check-go' to work from the toplevel.  Tested by
> running that command.  :-)
>
> OK to commit to the branch?  Or add libgo as lib-check-target also?
>
> I get two testsuite failures (with or without the patch):
>
> spawn [open ...]^M
> FAIL: ./tmp.go execution,  -O2 -g
> [...]
> $GOARCH: no such environment variable
> FAIL: go.test/test/env.go execution,  -O2 -g
>
> where the first one seems to come from pass 1 of go.test/test/index.go,
> and the second one goes away if I set GOARCH to amd64 or so.  Would be
> nice if the logging would not mention the temporary file name only.


By the way, I realized that the first failure is because you aren't
using the gold linker.  When not using gold, Go code is vulnerable to
stack overflow.  It's not common, as you can see by the fact that only
one test fails, but it's possible, just as it is in a multithreaded
C/C++ program.

Ian


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]