This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch libcpp]: PR/17349 - // comments cause weird behaviour with options -E -C


gcc-patches-owner@gcc.gnu.org wrote on 15.11.2010 18:59:58:

> >>>>> "Kai" == Kai Tietz <ktietz70@googlemail.com> writes:
> 
> Kai> this patch fixes the issue about -C and C++ comments as described 
in
> Kai> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=17349. This issue is 
that
> Kai> within argument passing c++ comments need to be transformed into
> Kai> C-style comments, too.
> 
> Thanks.
> 
> Kai> +  /* If we are currently in a directive or in agument parsing, 
then
> 
> Typo in "argument".

Thanks.

> Kai> +  clen = ((pfile->state.in_directive || pfile->state.
> parsing_args) && type == '/') ? len + 2 : len;
> 
> This line should be wrapped according to GNU coding standards.

Done.

> I think this patch should include a regression test.

Ok, added a testcase for gcc.dg/cpp

> Tom
> 

ChangeLog libcpp

        PR preprocessor/17349
        * lex.c (save_comment): Handle in argument passing c++
        comments special.

ChangeLog gcc/testsuite

        PR preprocessor/17349
        * gcc.dg/cpp/cmdlne-C3.c: New.

Ok for apply?

Regards,
 i.A. Kai Tietz

|  (\_/)  This is Bunny. Copy and paste Bunny
| (='.'=) into your signature to help him gain
| (")_(") world domination.

Attachment: pr17349.diff
Description: Binary data


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]