This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix combiner cfglayout issue (PR rtl-optimization/46440)


On 11/15/2010 09:21 PM, Jakub Jelinek wrote:
Hi!

On this testcase we ICE during flow checking, because
combiner replaced an indirect jump (which was before going into
cfglayout mode followed by BARRIER, which stays in the footer)
by direct unconditional jump.  Fixed by removing the BARRIER
from the footer in that case.

Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk?

Alternatively, perhaps the current_ir_type () == IR_RTL_CFGLAYOUT test
can be assumed to be 1.

Yes, in the end update_cfg_for_uncondjump is already assuming cfglayout mode.


I'm wondering what happens if you remove the BARRIER altogether in skip_insns_after_block. If it's just a matter of saving some garbage, it's not that much since we're going into/out of cfglayout mode 2-4 times per function.

Paolo


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]