This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix i386 *_cconly shifts (PR target/46088)


On 11/11/2010 07:35 AM, Jakub Jelinek wrote:
> -   && ix86_binary_operator_ok (ASHIFT, <MODE>mode, operands)"
> +   /* Can't use ix86_binary_operator_ok here, as the scratch
> +      operand might be missing.  */
> +   && !MEM_P (operands[1])"

Better to change the predicate on op1 to register_operand,
and drop the test here inside the extra predicate.

Ok with that change.


r~


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]