This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH, LIBSTDC++] Fix type_info equivalence test.


On 11/09/2010 11:43 AM, Marcus Shawcroft wrote:
> Hi,
>
> The attached patch fixes the failure of g++.dg/abi/local1.C observed on ARM
> linux-gnueabi. The type_info::operator== implementation obtains the type
> names for comparison by calling name(). The implementation of name() strips
> the leading  '*' prefix if present. The '*' prefix marker is emitted by gcc
> to force a pointer comparison. This patch replaces relevant name() call with
> a direct reference to __name to ensure the prefix if any is visible.
>
> Ok?
>   
The patch makes sense to me, but I think we should make sure that the
actual authors of that code and logic have a look and double check it:
can you please review the ChangeLog and in case add some CCs?

Thanks,
Paolo.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]