This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: RFA: Fix lm32 --enable-werror-always build


On 11/08/2010 07:31 AM, Joern Rennecke wrote:
>    switch (code)
>      {
> +      rtx temp;
> +
>      case LE:
>      case LT:
>      case LEU:
>      case LTU:
>        code = swap_condition (code);
> -      rtx temp = cmp0;
> +      temp = cmp0;
>        cmp0 = cmp1;
>        cmp1 = temp;
>        break;

I'd prefer to see a new block for the case, rather than
injecting into the switch block.  I.e.


  switch (code)
    {
    ...
    case LTU:
      {
	rtx temp;
	...
      }
      break;

Otherwise ok.


r~


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]