This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: (Re)allocation of allocatable arrays on assignment - F2003


Dear Tobias,

On Thu, Nov 4, 2010 at 10:09 AM, Tobias Burnus <burnus@net-b.de> wrote:
> On 11/04/2010 09:56 AM, Tobias Burnus wrote:
>>
>> On 11/04/2010 09:50 AM, Tobias Burnus wrote:
>>>>
>>>> Bootstrapped and regtested on FC9/x86_64 - OK for trunk?
>>>>
>> Before you commit, can you add [...]
>
> Another post script: Can you add a condition that no reallocation happens
> for coarrays/coindexed variables? That's not a correctness issue (the RHS
> must have the same size as the LHS -- otherwise the program is invalid) but
> a performance issue. [Actually, in terms of array bounds, it might also be a
> correctness issue.]

OK

>
> The attr.codimension check can be added at the same place as the
> attr.allocatable check as both is with regards to the right most partref.
> The coindexed check can be done by calling gfc_is_coindexed (expr).

Thanks for the pointer and for the review.  I had thought to change
the underscore in the option but sheer laziness won out :-)  I'll
implement all the other bits and pieces and will try to do the commit
tonight.

BTW Did you want the attribution for your part of the patch?

Cheers

Paul


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]