This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch committed] config.gcc: Add newlib-stdint.h for sh64* when newlib enabled
Ralf Corsepius <ralf.corsepius@rtems.org> wrote:
> This patch doesn't seem right to me, for 2 reasons:
>
> a) The fact a target is using newlib is independent of the architecture
> (here sh64).
>
> b) It is wrong to key using "newlib-stdint.h" to $with_newlib, because
> its possible to build recent gccs with --with-newlib, but without using
> newlib-stdint.h with a couple of tweaks to newlib (remove its stdint.h)
> and config.gcc (use use_gcc_stdint=provide).
>
> RTEMS is likely going to apply this approach in near future (I am
> working on it).
I agree that my patch isn't best approach in general. It's simply
a simple fix for sh64-elf testsuite failures. sh64 isn't a real
target for almost folks and sh64-elf with newlib may be a uniqe
target which is valuable to test. Of course, your plan looks fine.
Regards,
kaz