This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: new sign/zero extension elimination pass


> No problem, I discovered it the hard way (and had to rewrite fwprop's
> dataflow to work around it).

The other ZEE pass uses UD/DU chains though.  The now removed SEE pass used 
them as well.

> I think you're right, as Joseph confirmed.  There is one occurrence of
> flag_wrapv in simplify-rtx.c and zero in combine.c, so this means that
> indeed RTL treats PLUS/MINUS as wrapping.  I remember seeing more but
> my memory must be at fault.  Since it's so limited, the one occurrence
> that is there should be removed.

They were introduced to fix PR rtl-optimization/23047.

> If you can fix the performance issues that Eric has without a rewrite,
> and if it's not quadratic, I would have no problem at all with RTL.

Yes, I also think that the pass makes sense at the RTL level, as it does 
something that cannot be done (easily) elsewhere.  On the other hand, it's 
unfortunate to have 2 different ZEE passes.

-- 
Eric Botcazou


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]