This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch, libgfortran] PR43899 Wrong unused-variable warning with NAMELISTs
- From: Janne Blomqvist <blomqvist dot janne at gmail dot com>
- To: Jerry DeLisle <jvdelisle at frontier dot com>
- Cc: gfortran <fortran at gcc dot gnu dot org>, gcc patches <gcc-patches at gcc dot gnu dot org>
- Date: Wed, 3 Nov 2010 12:44:34 +0200
- Subject: Re: [patch, libgfortran] PR43899 Wrong unused-variable warning with NAMELISTs
- References: <4CD0F58C.5040806@frontier.com>
On Wed, Nov 3, 2010 at 07:39, Jerry DeLisle <jvdelisle@frontier.com> wrote:
> 2010-11-02 ÂJerry DeLisle Â<jvdelisle@gcc.gnu.org>
>
> Â Â Â ÂPR libgfortran/43899
> Â Â Â Â* runtime/error.c (generate_error): New function to generate a run
> Â Â Â Âtime warning message. Fix some whitespace.
generate_warning, not generate_error. The comment above the function
in the patch also suffers from the same problem. Also, the iexport()
line should be removed (see below).
> Â Â Â Â* gfortran.map: Add symbol for new function.
Please remove this. We don't need to export generate_warning, as it's
never called from outside the library.
If at some point in the future we need to do that, it can be exported then.
> Â Â Â Â* libgfortran.h: Add prototype for new function.
Due to the above, should be marked with internal_proto() instead of
iexport_proto().
Otherwise the patch looks good. Ok for trunk with the above changes.
--
Janne Blomqvist