This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Discussion about merging Go frontend
On 03/11/2010 04:45, Ian Lance Taylor wrote:
> Dave Korn <dave.korn.cygwin@gmail.com> writes:
>
>> On 03/11/2010 04:29, Ian Lance Taylor wrote:
>>> Dave Korn <dave.korn.cygwin@gmail.com> writes:
>>>
>>>> + secdata = xmalloc (length);
>>> secdata = XNEWVEC (char *, length);
>>>
>>> + free (secdata);
>>>
>>> XDELETEVEC (secdata);
>> The whole rest of the file (that I didn't change) is crawling with xmalloc,
>> xrealloc, xcalloc and free calls. I didn't want to break the convention. Do
>> I have to change them all as well?
>
> Well, no, I guess not. We can leave this for later.
>
>> The version prior to these changes bootstrapped OK, but the plugin didn't
>> work right, falling over a linker script. I need to investigate whether it
>> was gold or the plugin that was the actual source of the error.
>
> The "file not recognized" error is coming from simple_object_start_read,
> which (naturally) does not recognize the linker script as an object
> file. The LTO plugin code is reporting that error.
>
> Looking at the existing lto-plugin-elf.c, it simply returns LDPS_OK when
> it is given a filename at offset 0 which elf_begin can not open. I
> guess your code should do the same.
:) I see our emails crossed in the ether. Just preparing a (hopefully
final!) spin.
cheers,
DaveK