This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Discussion about merging Go frontend


On 03/11/2010 04:29, Ian Lance Taylor wrote:
> Dave Korn <dave.korn.cygwin@gmail.com> writes:
> 
>> +  secdata = xmalloc (length);
> 
> secdata = XNEWVEC (char *, length);
> 
> +  free (secdata);
> 
> XDELETEVEC (secdata);

  The whole rest of the file (that I didn't change) is crawling with xmalloc,
xrealloc, xcalloc and free calls.  I didn't want to break the convention.  Do
I have to change them all as well?

> I assume you ran both autoconf and autoheader.

  Yep.  And automake.

> This is OK with those changes if it bootstraps on GNU/Linux.

  The version prior to these changes bootstrapped OK, but the plugin didn't
work right, falling over a linker script.  I need to investigate whether it
was gold or the plugin that was the actual source of the error.

    cheers,
      DaveK


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]