This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 2/2] Add gcc-ar, gcc-ranlib, gcc-ld wrappers v2


On 10/29/2010 11:51 PM, Joseph S. Myers wrote:
On Fri, 29 Oct 2010, Paolo Bonzini wrote:

On 10/29/2010 08:14 PM, Andi Kleen wrote:
+ifeq ($(enable_plugin),yes)
+	$(INSTALL_SCRIPT) lto/gcc-ar $(DESTDIR)$(bindir)/$(AR_INSTALL_NAME)
+	$(INSTALL_SCRIPT) lto/gcc-ranlib
$(DESTDIR)$(bindir)/$(RANLIB_INSTALL_NAME)
+endif

In addition to what pointed out by Joseph (including the preference for a C implementation), this is also wrong for cross-compiling. It needs to be installed as $(DESTDIR)$(gcc_tooldir)/bin/$(AR_INSTALL_NAME) in that case.

I thought the point was to install a binary for users to use, not for internal use by other programs - that is, something in bindir, which is the place for user binaries, not gcc_tooldir/bin, which is the place for internal binaries. AR_INSTALL_NAME is the transformed name, suitable for use in bindir.

You're right. I was confused by gcc-ar using $BINDIR/gcc to locate gcc (which doesn't work for cross-compiling).


Paolo


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]