This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Vector shifting patch


On Wed, 27 Oct 2010, Artem Shinkarov wrote:

> Ok, then here are vector shifts only.

This version is getting closer:

> +In C it is possible to use shifting operators @code{<<, >>} on integer-type

The comma should be outside @code: @code{<<}, @code{>>}.

> Index: gcc/testsuite/gcc.c-torture/execute/vector-shift2.c
> ===================================================================
> --- gcc/testsuite/gcc.c-torture/execute/vector-shift2.c	(revision 0)
> +++ gcc/testsuite/gcc.c-torture/execute/vector-shift2.c	(revision 0)
> @@ -0,0 +1,60 @@
> +/* dg-do run */

dg- directives have no effect in gcc.c-torture/execute, and if they were 
to have an effect they'd need to be properly marked up: { dg-do run }.

> Index: gcc/testsuite/gcc.dg/vector-shift2.c
> ===================================================================
> --- gcc/testsuite/gcc.dg/vector-shift2.c	(revision 0)
> +++ gcc/testsuite/gcc.dg/vector-shift2.c	(revision 0)
> @@ -0,0 +1,61 @@
> +/* { dg-do run } */
> +/* { dg-options "-fno-var-tracking-assignments" } */

Why this option?  It seems to have no relation to the test.

Apart from that the C front-end changes seem OK.

-- 
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]