This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] On targets without setup for cfa_base_rtx don't try to replace sp/hfp (PR target/45250)
On 10/27/2010 02:37 PM, Jakub Jelinek wrote:
> I think we can drop !MAY_HAVE_DEBUG_STMTS || check here, I believe we
> can without it generate wrong debug info for -fno-var-tracking-assignments,
> on the other side that's what the code was doing before ...
Ok, let's do that then.
>> Also, it seems to me that compute_cfa_pointer is wrong in
>> that it should not effectively re-compute cfa_base_rtx, but
>> should use that existing decision.
>
> You mean using cfa_base_rtx instead of {frame,arg}_pointer_rtx
> or also just remembering the adjustment bias in vta_init_cfa_base
> in HWI static global and using it in compute_cfa_pointer?
> Just the former would still mean we'd need to have #ifdef...
Then let's use the later so that we consolidate the ifdef
into a single place.
r~