This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH][ARM] Optimized 64-bit multiplication for THUMB-1
- From: Paul Brook <paul at codesourcery dot com>
- To: "Doug Kwan (éæå)" <dougkwan at google dot com>
- Cc: "gcc-patches" <gcc-patches at gcc dot gnu dot org>, Nick Clifton <nickc at redhat dot com>, Richard Earnshaw <rearnsha at arm dot com>
- Date: Fri, 22 Oct 2010 19:20:34 +0100
- Subject: Re: [PATCH][ARM] Optimized 64-bit multiplication for THUMB-1
- References: <AANLkTi=A-ZuBARrxXJaJC4hz=J-oL4_5zYjbJ1w2d_nR@mail.gmail.com>
> +/* Force using ARM code if it is possible except for THUMB2 target. */
> +#if defined(USE_FAST_MULDI3) && !defined(__thumb2__)
> + ARM_FUNC_START muldi3
The !__thumb2__ test is wrong. I'm surprised this even compiles.
>+ mul xxh, yyl
>...
>+ add xxh, yyh
Please use the proper 3-argument form in 32-bit code.
>+ push {r4, r5, r6, r7}
Older assemblers do not support push/pop in ARM mode.
Use do_push/do_pop.
Paul