This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix ifcvt ICE

From: Chung-Lin Tang <cltang at codesourcery dot com>
To: Eric Botcazou <ebotcazou at adacore dot com>
Cc: gcc-patches at gcc dot gnu dot org
Date: Fri, 15 Oct 2010 03:30:55 +0800
Subject: Re: [PATCH] Fix ifcvt ICE
References: <4CB34E16.3020804@codesourcery.com> <201010130951.20037.ebotcazou@adacore.com>

Eric Botcazou wrote:

So this patch is quite simple: implement two replacement functions
find_active_insn_before/after() that correct the above mentioned
behavior, and use them in ifcvt.


OK on principle, but the implementation isn't fully correct because it uses
BLOCK_FOR_INSN and this isn't defined for BARRIERs.

Please add a BB parameter to both functions and test against BB_HEAD or BB_END
to stop the iteration, like in first_active_insn/last_active_insn.


Here's the updated patch, tests were ran again to verify same results.
Ok for trunk now?

Thanks,
Chung-Lin

Attachment: ifcvt.diff
Description: Text document

Follow-Ups:
- Re: [PATCH] Fix ifcvt ICE
  - From: Eric Botcazou

References:
- [PATCH] Fix ifcvt ICE
  - From: Chung-Lin Tang
- Re: [PATCH] Fix ifcvt ICE
  - From: Eric Botcazou

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]