Re: make recheck?

["H.J. Lu" <hjl dot tools at gmail dot com>]

On Sun, Oct 10, 2010 at 9:06 AM, Ralf Wildenhues <Ralf.Wildenhues@gmx.de> wrote:
> [ moving from gcc@ ]
>
> * Diego Novillo wrote on Sat, Oct 02, 2010 at 06:44:09PM CEST:
>> On Sat, Oct 2, 2010 at 05:54, Ralf Wildenhues wrote:
>>
>> > Asking because it could help speed up patch development:
>> > 1) hack hack hack
>> > 2) make -k check-$whatever
>> > 3) go back to (1) until satisfactory
>> > 4) git commit patch, undo patch in work tree, rebuild
>> > 5) run 'make recheck' to ensure all new failures were already old.
>>
>> This sounds like a great idea. ?You'd need to extract the FAIL lines
>> from the .log file and backtrack to figure out which .exp file
>> produced them. ?This would give you the input for
>> RUNTESTFLAGS=f.exp=...
>>
>> I don't recall if you can specify more than one file in the
>> RUNTESTFLAGS argument, though.
>
> You can specify more than one file, but the parallel check rules broke
> passing quoted content, which is needed for passing more than one test
> name per .exp file. ?The first patch below fixes that, but ...
>
> it turned out that it was still ugly to get things in a Makefile rule,
> so I ended up with an external script that doesn't yet use the make
> rules (so strictly, the first patch is not yet needed, but will be at
> some point). ?It also has the advantage of working outside of the gcc
> subdir.
>
> Longer term, I'd like to overhaul the Automake rules for dejagnu
> support, add the functionality there and in gcc/Makefile.in.
>
> The script has been tested lightly on a full build tree, so beware and
> use -n to see what would happen.
>
> OK for both patches?
>
> I suppose I should add code to backup old .sum files before rechecking
> next.
>
> Hmm, the parallel check rules also broke in-tree dejagnu (i.e.,
> extracting the dejagnu package sources below toplevel), I wonder if
> anybody uses that.
>
> Thanks,
> Ralf
>
> Fix quoting for RUNTESTFLAGS in gcc/.
>
> gcc/ChangeLog:
> 2010-10-10 ?Ralf Wildenhues ?<Ralf.Wildenhues@gmx.de>
>
> ? ? ? ?* Makefile.in ($(lang_checks_parallel))
> ? ? ? ?($(lang_checks_parallelized)): Use single quotes for
> ? ? ? ?$(RUNTESTFLAGS), to allow passing quoted content.
>

This patch is bogus and caused:

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45974


-- 
H.J.