This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 1/3] Add native ELF and LTO support in collect2
On Mon, Oct 11, 2010 at 02:33:07PM +0000, Joseph S. Myers wrote:
> On Mon, 11 Oct 2010, Andi Kleen wrote:
>
> > Controlled by a define in the OS specific config file.
> > I only enabled this on x86 Linux for now.
>
> OBJECT_FORMAT_ELF is already defined in elfos.h where it belongs (and in
> several target-specific headers where it doesn't belong - some duplicating
> the definition in elfos.h, others ELF targets that don't use elfos.h for
> whatever reason).
What do you suggest? Use a different name?
>
> > +#if !defined (HAVE_LIBELF_H) || !defined (HAVE_GELF_H) \
> > + || !defined (HAVE_UNISTD_H) || !defined (HAVE_FCNTL_H) \
> > + || defined (CROSS_DIRECTORY_STRUCTURE)
>
> Why the CROSS_DIRECTORY_STRUCTURE conditional?
I wasn't sure if the host libelf works from cross compilation.
Also some of the other elf format code had checks for it so
I thought it was safer to exclude.
-Andi