This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PATCH COMMITTED: Fix -fsplit-stack build with old binutils
- From: Nathan Froyd <froydnj at codesourcery dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: Ian Lance Taylor <iant at google dot com>, gcc-patches at gcc dot gnu dot org
- Date: Fri, 1 Oct 2010 04:50:47 -0700
- Subject: Re: PATCH COMMITTED: Fix -fsplit-stack build with old binutils
- References: <mcrfwwuvih7.fsf@google.com> <AANLkTim+5PWZSmnz5dNCzcthm6qoY9oN7WmQeTOpwNVx@mail.gmail.com>
On Fri, Oct 01, 2010 at 04:32:51AM -0700, H.J. Lu wrote:
> > 2010-09-27 ?Ian Lance Taylor ?<iant@google.com>
> >
> > ? ? ? ?* configure.ac: Test whether assembler supports CFI directives.
> > ? ? ? ?* config.host: Only add t-stack and i386/t-stack-i386 to
> > ? ? ? ?tmake_file if libgcc_cv_cfi is "yes".
> > ? ? ? ?* configure: Rebuild.
> >
>
> I checked in this patch to add the missing `$'.
>
> Index: config.host
> ===================================================================
> --- config.host (revision 164874)
> +++ config.host (working copy)
> @@ -610,7 +610,7 @@ i[34567]86-*-linux* | x86_64-*-linux* |
> i[34567]86-*-gnu*)
> tmake_file="${tmake_file} t-tls"
> if test "$libgcc_cv_cfi" = "yes"; then
> - tmake_file="{$tmake_file} t-stack i386/t-stack-i386"
> + tmake_file="${$tmake_file} t-stack i386/t-stack-i386"
> fi
> ;;
> esac
That looks *really* odd. Are you sure that's not supposed to be:
> - tmake_file="{$tmake_file} t-stack i386/t-stack-i386"
> + tmake_file="${tmake_file} t-stack i386/t-stack-i386"
That makes more sense.
-Nathan