This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH][Revised] Fix PR 36502/plugins
On Wed, Sep 29, 2010 at 02:31:04PM +0000, Joseph S. Myers wrote:
> On Sun, 26 Sep 2010, Mike Stump wrote:
>
> > On Sep 26, 2010, at 8:11 AM, Jack Howarth wrote:
> > > The following patch restores plugin support for darwin which
> > > was broken by the changes replacing translate_options with the
> > > .opt option alias facility and handling variants in r164531.
> > > Bootstrap and regression tested on x86_64-apple-darwin10. Okay
> > > for gcc trunk?
> >
> > Barring someone wanting to fix it some other way (a generic, non-darwin
> > type patch), Ok.
>
> I don't really see what could make sense here as a generic patch. A
> principle of my option-handling patches is that in the end all options the
> compiler knows about should be described in .opt files - SWITCH_TAKES_ARG
> and WORD_SWITCH_TAKES_ARG (presently used to work out whether an unknown
> option, that might be handled by specs, takes arguments, and to process
> options generated by specs modifying the driver's own command line) should
> go away (as should the possibility of defining an option that doesn't take
> arguments solely in specs). So adding any option not presently included
> in the .opt files to those files is a move in the correct direction.
>
Joseph,
In that case, could you go ahead and commit the revised patch...
http://gcc.gnu.org/ml/gcc-patches/2010-09/msg02054.html
My concern is that darwin be able to build plugin support for gcc 4.6
so that the dragonegg developers can continue to work on the darwin target.
Jack
> > > 2010-09-26 Joseph Myers <joseph@codesourcery.com>
> > > Jack Howarth <howarth@bromo.med.uc.edu>
> > >
> > > PR 45787/target
> > >
> > > * gcc/config/darwin.opt: Add "undefined Driver Separate"
> >
>
> --
> Joseph S. Myers
> joseph@codesourcery.com