This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Support official CLooG.org versions.

From: Paolo Bonzini <bonzini at gnu dot org>
To: Sebastian Pop <sebpop at gmail dot com>
Cc: Andreas Simbürger <simbuerg at googlemail dot com>, gcc-patches at gcc dot gnu dot org, gcc-graphite at googlegroups dot com
Date: Wed, 29 Sep 2010 16:12:50 +0200
Subject: Re: [PATCH] Support official CLooG.org versions.
References: <4C8DDE4E.7000608@googlemail.com> <1284373878-20753-1-git-send-email-simbuerg@googlemail.com> <AANLkTikAVyeaLJ8WZT1rFBEM6h01HhnLNjj=PXXJaxqx@mail.gmail.com>

On 09/22/2010 04:16 PM, Sebastian Pop wrote:

 -if test "x$with_cloog_include" != x; then
 -  clooginc="-I$with_cloog_include -DCLOOG_PPL_BACKEND "
 +if test "${with_cloog_include+set}" = set ; then
 +  clooginc="-I$with_cloog_include"
   fi
 -if test "x$with_cloog_lib" != x; then
 -  clooglibs="-L$with_cloog_lib -lcloog"
 +if test "${with_cloog_lib+set}" = set; then
 +  clooglibs="-L$with_cloog_lib"
   fi

I don't understand the change in the "if" statements, since -I and -L do not make sense if the variable is empty.

Also, this is now a substantial body of code, can you move it to config/cloog.m4 please?

Paolo

Follow-Ups:
- Re: [PATCH] Support official CLooG.org versions.
  - From: Andreas Simbuerger

References:
- Re: [PATCH] Support official CLooG.org versions.
  - From: Andreas Simbuerger
- [PATCH] Support official CLooG.org versions.
  - From: Andreas SimbÃrger
- Re: [PATCH] Support official CLooG.org versions.
  - From: Sebastian Pop

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]