This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH][Revisedx2] eliminate UNRESOLVED errors on attr-ifunc-[1,5].c/attr-ifunc-[1,4].C
- From: Mike Stump <mikestump at comcast dot net>
- To: Jack Howarth <howarth at bromo dot med dot uc dot edu>
- Cc: gcc-patches Patches <gcc-patches at gcc dot gnu dot org>
- Date: Sun, 26 Sep 2010 11:52:39 -0700
- Subject: Re: [PATCH][Revisedx2] eliminate UNRESOLVED errors on attr-ifunc-[1,5].c/attr-ifunc-[1,4].C
- References: <20100924003525.GA1035@bromo.med.uc.edu> <4C9F88B6.6090906@codesourcery.com>
On Sep 26, 2010, at 10:53 AM, Nathan Sidwell wrote:
> On 09/24/10 01:35, Jack Howarth wrote:
>> Currently on targets like darwin which lack alias support in their object file
>> format, the ifunc test case gcc.dg/attr-ifunc-1.c erroneously reports as UNRESOLVED.
>> This is due to the fact that assemble_alias() is called before the error can be
>> emiited in do_assemble_alias(). Thus an inappropriate error message is given. The
>> attached patch resolves this by checking for the ifunc attribute and emitting the
>> correct error message in assemble_alias. Bootstrap and regression tested on
>> x86_64-apple-darwin10. Okay for gcc trunk?
>
> this seems sensible, unfortunately I cannot approve it.
I likewise, want an ifunc person to review approve it. The darwin aspects of it look fine to me.
Hey, I had a random though, can we delay codegen using lto so that we can support more codegen things, like aliases, elf style weaks and ifunc on darwin? That'd be a curious way to gain more compatibility... [ this is just a wild thought, don't laugh at me :-) ]