This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch, Fortran] PR fortran/45776: More variable definition checks


On 09/24/2010 02:06 PM, Daniel Kraft wrote:
Here's an updated patch with the suggestions and IRC discussion incorporated --
earlier than I expected, but anyways ;)

What do you think about the new solution? I will run a fresh regtest tomorrow,
but at least the io_*, write_*, read_* and namelist_* tests seem to pass. Ok?


Looking pretty good. What about this?


-	      /* Free this pointer now so that a warning/error is not triggered
-		 below for the "Extension".  */
-	      gfc_free_expr (dt->extra_comma);
+	      /* Nullify this pointer now so that a warning/error is not
+		 triggered below for the "Extension".  */
 	      dt->extra_comma = NULL;

If the *expr extra_comma is not already NULL then how can it's memory be freed later if it is set to NULL here?

Regards,

Jerry


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]