This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: PATCH: PR testsuite/45719: Fix gcc.target/i386/pad-3.c

From: "H.J. Lu" <hjl dot tools at gmail dot com>
To: Richard Guenther <richard dot guenther at gmail dot com>
Cc: gcc-patches at gcc dot gnu dot org
Date: Sat, 18 Sep 2010 11:17:32 -0700
Subject: Re: PATCH: PR testsuite/45719: Fix gcc.target/i386/pad-3.c
References: <20100918162651.GA25740@intel.com> <AANLkTi=+ruCduuOd1pUUmvRPVeTdDYLB2vmvZwMwqd8T@mail.gmail.com>

On Sat, Sep 18, 2010 at 11:11 AM, Richard Guenther
<richard.guenther@gmail.com> wrote:
> On Sat, Sep 18, 2010 at 6:26 PM, H.J. Lu <hongjiu.lu@intel.com> wrote:
>> Darwin enables PIC by default. ?I checked in this patch to pass -fno-pic
>> to gcc.target/i386/pad-3.c as an obvious fix.
>
> You should use { dg-require-effective-target nonpic } instead.
>
>

Won't it skip the test on Darwin?

This testcase checks we only pad small functions. Since we
will always pad PIC thunk, we get false positive on Darwin.
-fno-pic removes PIC thunk so that we can run this test for
all x86 targets.


-- 
H.J.

Follow-Ups:
- Re: PATCH: PR testsuite/45719: Fix gcc.target/i386/pad-3.c
  - From: Richard Guenther

References:
- PATCH: PR testsuite/45719: Fix gcc.target/i386/pad-3.c
  - From: H.J. Lu
- Re: PATCH: PR testsuite/45719: Fix gcc.target/i386/pad-3.c
  - From: Richard Guenther

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]