This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PING: PATCH: PR middle-end/45234: [4.4/4.5/4.6 Regression] ICE in expand_call, at calls.c:2845 when passing aligned function argument from unaligned stack after alloca
- From: Richard Henderson <rth at redhat dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Fri, 17 Sep 2010 10:52:07 -0700
- Subject: Re: PING: PATCH: PR middle-end/45234: [4.4/4.5/4.6 Regression] ICE in expand_call, at calls.c:2845 when passing aligned function argument from unaligned stack after alloca
- References: <20100826161919.A13913BE18@mailhost.lps.ens.fr> <AANLkTinU5tc8jyoEED0WE4TeTu8cN81PyGBT7TLpKOLY@mail.gmail.com> <AANLkTi=vhVjJLdmdrSN6O0oc21MxrfWjsNMRjhy==jnc@mail.gmail.com>
On 09/17/2010 08:55 AM, H.J. Lu wrote:
> On Thu, Aug 26, 2010 at 10:18 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
>> On Thu, Aug 26, 2010 at 9:19 AM, Dominique Dhumieres <dominiq@lps.ens.fr> wrote:
>>> On x86_64-apple-darwin10.4.0 this patch caused the following failures:
>>> FAIL: g++.dg/eh/async-unwind2.C execution test
>>> FAIL: gcc.c-torture/execute/struct-ret-1.c execution, -Os
>>> FAIL: libgomp.c++/collapse-2.C -O1 execution test
>>> FAIL: libgomp.c++/for-1.C -O1 execution test
>>> FAIL: libgomp.c++/for-8.C -O1 execution test
>>> at r163063 and with -m32.
>>>
>>
>> I need to take pending_stack_adjust into account. I am testing it on Linux/ia32
>> and Linux/x86-64. Can you try this new patch on Darwin?
>>
>
> PING.
>
> http://gcc.gnu.org/ml/gcc-patches/2010-08/msg01916.html
This is ok, I guess.
All these sorts of scattered patches suggests that it would be
better to have a new pass scan the entire function to collect
the desired stack alignment, rather than scatter code all over
the place. That's probably not in the cards for 4.6 though,
unless someone gets busy in a hurry.
r~