This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: gengtype improvements for plugins, completed! Remaining questions & work (& hope for help & review)


2010/9/11 Basile Starynkevitch <basile@starynkevitch.net>:
> Second, to all the kind people who did comment about our gengtype
> work, could they check that I somehow adressed their comment (except
> identation issues). I probably forgot some suggestions, but only by
> mistake. ÂIf you feel I did not address (either by explaining in an
> email, or inside my patch proposal) some particular issue you did tell
> me, please remind it kindly to me.

I cross-checked against my previous comments, but I do think that the
burden is on you on this one. You can check the mailing list archives.

> Laurynas suggested me to avoid backing up generated gt*.[ch] files
> when they changed. I was thinking of adding a new program option to
> gengtype, eg --backup or -B, so that
> Âgengtype -B .old .... [other gengtype options omitted]
> would back-up every changed Âgenerated gtFOO.h file into gtFOO.h.old
> Is that acceptable?

I believe that since this is easily achievable by other means, such
option is not necessary.

> Should gengtype have a default state file to read in plugin mode? How
> to wire-in such a default file?

Why would you want to do that?

> How to have gengtype program installed? Under what name? gcc-gengtype?
> Does the --program-suffix passed at ./configure time should matter (so
> should it be gcc-gengtype-4.6 if ./configure-d with
> --program-suffix=-4.6 or what)? ÂHow to do that? ÂThere are subtle
> cross compilation issues I don't understand!!

I think the cross-compilation issues need to be worked out first (see
my other mail), and then answers to these questions will come more
naturally.

> I will perhaps try to send a third round of this serie, very probably
> in a single big email with 7 relative patches and ChangeLog entries.

I think it is better to have separate emails (if different folks will
want to comment on different patches, single e-mail thread will grow
unmanageable)

-- 
Laurynas


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]