Re: gengtype improvements for plugins, completed! patch 1/N [declprog]

[Paolo Bonzini <bonzini at gnu dot org>]

On 09/09/2010 08:07 AM, Basile Starynkevitch wrote:
> I still don't understand who has a reviewer hat

Everybody can informally review patches, including you.

Instead, what MAINTAINERS tell you is who approve patches; "maintainers" 
do not need external reviews, "reviewers" do.  Maybe "committers" and 
"maintainers" could be a better choice of words, but that's too late now 
to change it.

There are 2*2 possible scenarios which involve reviews from people not 
in MAINTAINERS:

1) Ralf reviews the patch and finds it is okay.  After I read his 
review, I still have to approve it explicitly if I agree, or reject it 
if I disagree.

2) I approve the patch, but Ralf comes and finds something I missed. 
It's usually good manners on your part to avoid committing the patch 
until I come back and resolve the problem (usually by rejecting the 
patch :).

3) Laurynas comes first and he points out problems in your patch.  The 
actual maintainers/reviewers usually will not reject the patch 
explicitly if they agree with him, but you should assume they do.  Maybe 
they can say "Ok with the changes suggested by Laurynas", in which case 
you can fix the changes and commit the patch.

4) Laurynas points out problems in your patch, the actual 
maintainers/reviewers disagree.  They start a discussion and you'll 
notice it.


To some up, usually you should pay more attention to bad news than to 
good news if you want your patches to go in. :)

Also, for patch series as big as this one you should really, really 
learn quilt or git.  (I wrote my own simplified version of quilt, but I 
was a student when I did...).

Paolo